lightning-dev-site icon indicating copy to clipboard operation
lightning-dev-site copied to clipboard
verified publisher icon lightninglabs

Stage 2 major review

Open magomimmo opened this issue 7 years ago • 3 comments

I wrote a major review of the stage 2 tutorial, the one on lncli-web.

magomimmo avatar Dec 28 '17 17:12 magomimmo

Just take into account that the stage 1 included in this PR is still the one in your master and not the PR I pushed yesterday.

magomimmo avatar Dec 28 '17 17:12 magomimmo

Hi, I'm no maintainer here but two things:

  • imho you should not include commits of another PR (https://github.com/lightninglabs/lightning-dev-site/pull/16) into this PR to keep every PR atomic and clean.
  • please always reference your corresponding issue in your PR so that everybody knows that they belong to each other and can be closed when the PR is merged (this one refers to issue https://github.com/lightninglabs/lightning-dev-site/issues/15)

ndeet avatar Dec 29 '17 21:12 ndeet

@ndeet you're totally right. My fault. Sorry about that. My only excuse is that this a text repository, not a code repository, but you're right anyway.

magomimmo avatar Dec 29 '17 22:12 magomimmo