lightning-app icon indicating copy to clipboard operation
lightning-app copied to clipboard

Feature Request: Delete "in-progress" transaction requests.

Open fresheneesz opened this issue 8 years ago • 5 comments

I have a couple transaction requests that probably will never be fulfilled. I'd like to delete them.

fresheneesz avatar Oct 16 '17 02:10 fresheneesz

I was looking through the API ref and there isn't any API to delete invoices. APIs only support adding, listing and searching invoices. Is invoice deletion even possible?

bulenttastan avatar Dec 19 '17 06:12 bulenttastan

Deleting invoices isn't currently exposed on the API (not that we're not open to changing that). As they are financial records, individuals may want to keep these records for some time. They're easily exported as JSON files (via the RPC) so that provides users a way to store them, then later signal to lnd that it's safe to garbage collect the old records.

Roasbeef avatar Dec 19 '17 17:12 Roasbeef

@Roasbeef How about an archive mechanism where it simply hides them from the interface?

fresheneesz avatar Dec 19 '17 21:12 fresheneesz

I can think of 3 ways of doing this:

  1. Expose the invoice deletion API and actually delete the pending invoices via lnd.
  2. Have an option on the UI to hide the pending invoices. We could save this option locally in the app but that will require a small DB sort of thing to keep the settings.
  3. Have an option on the UI but this time don't store any settings. The user will need to recheck the 'hide pending' setting every time the app restarts.

It would be ideal to do it through the APIs. That way the UI will not have any discrepancy with the backend.

bulenttastan avatar Dec 20 '17 03:12 bulenttastan

I just came back to this. The app is much improved! Still some kinds tho, including this. I'm just playing around on testnet, but I accidentally tried sending a lightning payment to the node before it was funded and now I have a line in my transactions list that will never be completed. The transaction lines should be greyed out or something if they're old and never confirmed/completed. I haven't waited long enough to know if they do something like that, but I'd hope they do.

fresheneesz avatar Aug 05 '19 02:08 fresheneesz