lightning-app icon indicating copy to clipboard operation
lightning-app copied to clipboard
verified publisher icon lightninglabs

Redirect navigation flow for 0 value invocies. Fixes #991

Open emiljoha opened this issue 5 years ago • 3 comments

  • [x] Functionality in desktop. (Tested on Linux)
  • [x] Functionality in mobile (Tested on android)
  • [x] Fix: Background on new view does not properly match views before and after.
  • [x] Make sure text content and placement is consitent with rest of the app.
  • [x] Fix: Input field on Desktop becomes 0500 when trying to write 500.
  • [x] Error handling. Make sure all error scenarios are considered and handled properly. (Note: My experience in UI coding is limited but I am currently convinced this new feature will handle errors gracefully)

more-or-less-polished

emiljoha avatar Jan 12 '20 10:01 emiljoha

@bolatovumar Thank you for you comments! Have tried to address the issues.

emiljoha avatar Feb 01 '20 12:02 emiljoha

@Roasbeef (Pinging you as you where the originator of the issue and the only one that have merged commits into to this repository for the last couple of months.)

The change is IMHO ready and has been reviewed by @bolatovumar. Please advice if there are any further steps needed to be taken in order to move forward in solving this issue.

emiljoha avatar Feb 08 '20 21:02 emiljoha

I have reviewed the PR and it looks good to me. I have not tested it, however.

bolatovumar avatar Feb 08 '20 22:02 bolatovumar