rust-lightning icon indicating copy to clipboard operation
rust-lightning copied to clipboard

test: add test for offer parsing with empty paths and valid issuer

Open erickcestari opened this issue 4 months ago • 3 comments

Verifies that offers with empty paths are accepted as long as the issuer_id is set.

Follow-up: #4018

erickcestari avatar Aug 18 '25 15:08 erickcestari

👋 Hi! This PR is now in draft status. I'll wait to assign reviewers until you mark it as ready for review. Just convert it out of draft status when you're ready for review!

ldk-reviews-bot avatar Aug 18 '25 15:08 ldk-reviews-bot

Codecov Report

:x: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 88.84%. Comparing base (5314ebb) to head (35a1693). :warning: Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/offers/offer.rs 66.66% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4020      +/-   ##
==========================================
- Coverage   88.86%   88.84%   -0.02%     
==========================================
  Files         175      175              
  Lines      127725   127731       +6     
  Branches   127725   127731       +6     
==========================================
- Hits       113501   113486      -15     
- Misses      11662    11684      +22     
+ Partials     2562     2561       -1     
Flag Coverage Δ
fuzzing 21.76% <ø> (ø)
tests 88.68% <66.66%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Aug 18 '25 15:08 codecov[bot]

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

ldk-reviews-bot avatar Aug 19 '25 15:08 ldk-reviews-bot