lightningdevkit
Simplify serialization where backwards compat. to LDK prior 0.0.113 kept us from doing so
In https://github.com/lightningdevkit/rust-lightning/pull/2708 we broke compatibility with serialization prior to 0.0.113.
We should explore what parts of our serialization can be simplified now that we don't need to provide backwards compat prior to 0.0.113 anymore.
I don't see breaking compatibility discussed in #2708. Was there a discussion and analysis of the pros/cons to doing so?
There was some discussion on Discord, but we're not breaking backwards compatibility, only forwards compatibility. ie you can upgrade from 0.0.112 to the latest, but you can't upgrade then downgrade to 0.0.112. We didn't discuss it in detail, but 0.0.113 is nearly a year old, and the failure will be explicit, so it seemed fine.
Dropping the milestone entirely cause there's no reason to do this at any specific rate. Also there's no specific changes outlined here so hard to know when its "done".
Dropping the milestone entirely cause there's no reason to do this at any specific rate. Also there's no specific changes outlined here so hard to know when its "done".
if there is no user I agree that there is not reason to fix this. However, would be nice to ensure that you can upgrade and downgrade from one aversion to another to make full node implementation easy. However, this kind of upgrade will depends also by the user application
We absolutely support that, in this case we broke downgrades if you downgrade almost a year of versions. In general we absolutely support downgrades at least one or two versions and try to support more, but we are willing to break it after a while.
Post-#3604 we even removed the ability to read objects written by LDK 0.0.113. Thus, we can now go further!