plugins icon indicating copy to clipboard operation
plugins copied to clipboard

fix: a lot of tests and broken stuff

Open m-schmoock opened this issue 3 years ago • 4 comments
trafficstars

This is a general cleanup PR that aims to fix issues that got raised by outdated code and upstream changes.

m-schmoock avatar Sep 16 '22 16:09 m-schmoock

... will still fix the tests for backup and feeadjuster plugin

m-schmoock avatar Sep 16 '22 16:09 m-schmoock

@cdecker we need to synchronize some efforts here with your recent fix-gci https://github.com/lightningd/plugins/tree/fix-gci branch

m-schmoock avatar Sep 24 '22 12:09 m-schmoock

Yeah, was looking mostly to fix from an infra point of view (test runner script, virtualenvs setup, etc), not so much on fixing individual plugins, though I did try to fix some things on the side

cdecker avatar Sep 24 '22 12:09 cdecker

Yeah, was looking mostly to fix from an infra point of view (test runner script, virtualenvs setup, etc), not so much on fixing individual plugins, though I did try to fix some things on the side

Not sure now who wants to rebase, but no problem.

m-schmoock avatar Sep 28 '22 11:09 m-schmoock

@rustyrussell I used the semver, though its kinda overkill, especially since it does not even filter out/ignore the 'v' in front of the version string. Some ppl might complain if they don't update their pip environment for a module that only does a string split :D

@gallizoltan

see 4544d51 on the listpays status version check...

@ anyone else If there is no objections on this PR (even though CI is not clean, but thats a topic for another day) I will merge this.

m-schmoock avatar Oct 26 '22 09:10 m-schmoock