plugins icon indicating copy to clipboard operation
plugins copied to clipboard

commando-reader=<id>: unrecognized option (is commando_reader)

Open jsarenik opened this issue 2 years ago • 1 comments

No matter if used as a command-line parameter with --commando-reader=<id> or in config file as commando-reader=<id>

The option which works is commando_reader in the config file and --commando_reader in command line of lightningd.

So no dash, but underscore. Will do a PR for the readme in a moment.

jsarenik avatar Mar 03 '22 09:03 jsarenik

Yes looks like it's wrong in the plugin: https://github.com/lightningd/plugins/blob/master/commando/commando.py#L418

In other plugins, the argument definitions use - e.g. https://github.com/lightningd/plugins/blob/master/donations/donations.py#L191

I think simply search-and-replacing the snake_case with kebab-case spelling throughout the implementation files will do it.

laanwj avatar Apr 12 '22 10:04 laanwj