Aaron

Results 29 comments of Aaron

> please add a method to get all the set elements, like: > > ``` > public fun into_keys(self: SimpleSet): vector > ``` Can you explain the necessity as `SimpleMap`...

@movekevin Think of undroppable(uncopyable) objects, how do you want to use it with `set`? Do you remember why `Table` has key type copyable required?.. For example, `contains()` need a `&Key`...

> I'm fine with this, but I wonder why we didn't just make a dummy value and use SimpleMap. > > `SimpleMap` where `struct DummyValue has store { }` I...

> extensionality > I don't think we can have this part of our framework and call it a "set" because it doesn't has a very simple property important for sets:...

> do you want to rename this unordered_set? Why? Do you rename `simple_map` to `unordered_map`? btw, do we have any plan to implement native implementation for simple_map that it reads...

cc @movekevin .Please take a look at @wrwg 's comment. Then let's hold off putting this inside framework and you can use simple_map for now for multi-sig acct.

AIP https://github.com/aptos-foundation/AIPs/pull/280

@davidiw @davidiw @davidiw @davidiw @davidiw @davidiw @davidiw @movekevin @movekevin @movekevin @movekevin @movekevin @movekevin