lightly icon indicating copy to clipboard operation
lightly copied to clipboard

Bugfix DockerWorkerSelectionConfig to support all parameters

Open MalteEbner opened this issue 3 years ago • 1 comments

Review this together with the changed API specs: https://github.com/lightly-ai/lightly-core/pull/1834

Changes

  • generates code from the new API specs in the linked PR
  • includes a unittest checking that the new code works and does not drop any parameters.
  • closes LIG-1610

How has it been tested

  • unittest
  • with an actual scheduled docker run: The selection works, but it fails with [2022-08-10 13:08:32] An unexpected exception occured in the compute worker: Object of type _SpecialForm is not JSON serializable, which is handled by https://linear.app/lightly/issue/LIG-1611/advanced-selection-scheduling-bug-typingany-not-jsonable

MalteEbner avatar Aug 09 '22 15:08 MalteEbner

Codecov Report

Merging #894 (8284b73) into master (af81f34) will increase coverage by 0.31%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #894      +/-   ##
==========================================
+ Coverage   88.89%   89.20%   +0.31%     
==========================================
  Files          97       97              
  Lines        4285     4346      +61     
==========================================
+ Hits         3809     3877      +68     
+ Misses        476      469       -7     
Impacted Files Coverage Δ
lightly/api/api_workflow_compute_worker.py 100.00% <100.00%> (ø)
lightly/api/api_workflow_client.py 99.40% <0.00%> (+1.24%) :arrow_up:
lightly/api/api_workflow_download_dataset.py 92.94% <0.00%> (+7.05%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 09 '22 15:08 codecov[bot]