lightly icon indicating copy to clipboard operation
lightly copied to clipboard

Unmocked tests: cover more cases

Open MalteEbner opened this issue 3 years ago • 0 comments

Current state

The unmocked tests for CLI commands also used in the CI cover already quite some cases. https://github.com/lightly-ai/lightly/blob/master/tests/UNMOCKED_end2end_tests/run_all_unmocked_tests.sh

We also have CI script for the CLI commands magic and upload, which need the API: https://github.com/lightly-ai/lightly/blob/e18656578886f7a3eacfa6a052ef5d537bef5460/.github/workflows/tests_unmocked.yml#L21-L24

Description

The unmocked should ideally cover all CLI examples for all the API-related commands. Currently, it does not cover the download command and not all upload commands, due to the dataset_id and embeddings_path not being accessible. https://github.com/lightly-ai/lightly/blob/e18656578886f7a3eacfa6a052ef5d537bef5460/lightly/cli/upload_cli.py#L201-L228 https://github.com/lightly-ai/lightly/blob/e18656578886f7a3eacfa6a052ef5d537bef5460/lightly/cli/download_cli.py#L131-L141

Dependencies

  • #607

MalteEbner avatar Nov 30 '21 13:11 MalteEbner