lightly icon indicating copy to clipboard operation
lightly copied to clipboard

Published 20 hours ago • verified publisher icon lightly-ai

Add PIRL

Open ramdhan1989 opened this issue 3 years ago • 17 comments

Is there any plan to add PIRL ?

ramdhan1989 avatar Jun 04 '21 02:06 ramdhan1989

Yes, we'd like to add PIRL to the framework. However, I can't provide a timeline on this since we're currently planning to do a refactoring of the existing models.

Would you be interested in working on PIRL yourself? It would be a great addition to lightly :)

philippmwirth avatar Jun 04 '21 14:06 philippmwirth

yeah, I would be happy to help.

ramdhan1989 avatar Jun 25 '21 15:06 ramdhan1989

Cool! I think a good first step would be to add the "jigsaw" augmentation to lightly.transforms.

If you need any information on how to contribute, please take a look at our contribution guide.

The reference paper is here.

Let me know if you there are any questions, I'm happy to help :)

philippmwirth avatar Jun 28 '21 07:06 philippmwirth

I'm not sure if this issue is still resolved. If not, can this be assigned to me? I'd love to work on this.

shikharmn avatar Aug 25 '21 14:08 shikharmn

Hi @shikharmn, the issue is not resolved. You're very welcome to work on it. Can I assign the issue to you?

philippmwirth avatar Aug 25 '21 15:08 philippmwirth

Yeah, sure! Should I submit a PR for the jigsaw augmentation first?

shikharmn avatar Aug 25 '21 15:08 shikharmn

Sure, sounds good!

philippmwirth avatar Aug 25 '21 15:08 philippmwirth

Apologies for the delay, do check out #477 and let me know if any changes are needed.

shikharmn avatar Aug 30 '21 04:08 shikharmn

Hi @shikharmn and thanks a lot for your contribution! I think the next step would be to write a collate function for PIRL (see other collate functions for inspiration).

philippmwirth avatar Sep 24 '21 07:09 philippmwirth

Okay, sure! I'll start with that and get back to you if I face any issues.

shikharmn avatar Sep 24 '21 12:09 shikharmn

Hi @philippmwirth, is this still relevant? Can pick this up again now.

(sorry, was drowned with uni work)

shikharmn avatar Jun 21 '22 21:06 shikharmn

Yes sure, I think we can move ahead with this one 👍

philippmwirth avatar Jun 22 '22 07:06 philippmwirth

Hi @philippmwirth, do let me know if #850 is okay.

shikharmn avatar Jun 24 '22 12:06 shikharmn

Hey @shikharmn sorry for not replying! I'm quite busy right now but I'll try to take a look ASAP. Thanks a ton for your contribution 🙂

philippmwirth avatar Jun 24 '22 12:06 philippmwirth

Ah no worries, I didn't know if the notification reached you, do take a look whenever you find the time! :)

shikharmn avatar Jun 24 '22 12:06 shikharmn

Thank you @guarin for approving the PR #850! I'll move on to writing the PIRL network and related loss function now to finish this up. Do let me know if there's any details regarding that task which I should keep in mind.

shikharmn avatar Jun 27 '22 07:06 shikharmn

Awesome work @shikharmn! Looking forward to your future contributions 🙂

philippmwirth avatar Jun 27 '22 07:06 philippmwirth