lightly
lightly copied to clipboard
Move config files and setup.py to pyproject.toml
We would like to move to pyproject.toml for package configuration. @SauravMaheshkar made a PR (#1081 ) for this but it turned out to be more involved than expected.
TODO:
- [ ] Figure out how to move everything from
setup.pytopyproject.toml - [ ] Move
setup.pyand test on old python versions (3.6, 3.7) - [x] Check if we have to upgrade
setuptoolsdependency (setuptoolsonly supportspyproject.tomlfrom version 61.0.0) - [x] Move other configuration files to
pyproject.toml- [ ] (skip)
pylintrc - [x]
.coveragerc - [x]
mypy.ini
- [ ] (skip)
- [ ] Check if we can also move requirement files to
pyproject.toml
@guarin Maybe we could break this down into smaller tasks and try to achieve this using subsequent smaller PRs. I think the easiest to start would be moving coverage and mypy.ini into pyproject.toml. Skipping pylint for now since it's rather verbose.
Hi, yes .coveragerc or mypy.ini could be a good start and a PR would be very welcome. I agree that adding pylint doesn't make sense for now, especially because we don't enforce linting right now.
@guarin with #1549 merged what parts of the above checklist are still to be fixed considering #1149 as well.
Thanks for your work, @SauravMaheshkar. I have updated the original comment to track progress.
I think a good next step would be to move the dependencies from requirements/*.txt to the pyproject.toml. Let's try to maintain the structure (base, dev, minimal, etc): https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#dependencies-and-requirements
I think a good next step would be to move the dependencies from
requirements/*.txtto thepyproject.toml. Let's try to maintain the structure (base, dev, minimal, etc): https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#dependencies-and-requirements
Thanks will work on that next !
Completed in #1559