lightly icon indicating copy to clipboard operation
lightly copied to clipboard

Move config files and setup.py to pyproject.toml

Open guarin opened this issue 2 years ago • 6 comments
trafficstars

We would like to move to pyproject.toml for package configuration. @SauravMaheshkar made a PR (#1081 ) for this but it turned out to be more involved than expected.

TODO:

  • [ ] Figure out how to move everything from setup.py to pyproject.toml
  • [ ] Move setup.py and test on old python versions (3.6, 3.7)
  • [x] Check if we have to upgrade setuptools dependency (setuptools only supports pyproject.toml from version 61.0.0)
  • [x] Move other configuration files to pyproject.toml
    • [ ] (skip) pylintrc
    • [x] .coveragerc
    • [x] mypy.ini
  • [ ] Check if we can also move requirement files to pyproject.toml

guarin avatar Mar 01 '23 09:03 guarin

@guarin Maybe we could break this down into smaller tasks and try to achieve this using subsequent smaller PRs. I think the easiest to start would be moving coverage and mypy.ini into pyproject.toml. Skipping pylint for now since it's rather verbose.

SauravMaheshkar avatar May 22 '24 19:05 SauravMaheshkar

Hi, yes .coveragerc or mypy.ini could be a good start and a PR would be very welcome. I agree that adding pylint doesn't make sense for now, especially because we don't enforce linting right now.

guarin avatar May 23 '24 06:05 guarin

@guarin with #1549 merged what parts of the above checklist are still to be fixed considering #1149 as well.

SauravMaheshkar avatar Jun 15 '24 12:06 SauravMaheshkar

Thanks for your work, @SauravMaheshkar. I have updated the original comment to track progress.

philippmwirth avatar Jun 17 '24 07:06 philippmwirth

I think a good next step would be to move the dependencies from requirements/*.txt to the pyproject.toml. Let's try to maintain the structure (base, dev, minimal, etc): https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#dependencies-and-requirements

philippmwirth avatar Jun 17 '24 07:06 philippmwirth

I think a good next step would be to move the dependencies from requirements/*.txt to the pyproject.toml. Let's try to maintain the structure (base, dev, minimal, etc): https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#dependencies-and-requirements

Thanks will work on that next !

SauravMaheshkar avatar Jun 17 '24 07:06 SauravMaheshkar

Completed in #1559

guarin avatar Jul 10 '24 07:07 guarin