lightdash icon indicating copy to clipboard operation
lightdash copied to clipboard

feat: add screenshot ready indicator for more reliable dashboard captures

Open pimmey opened this issue 2 weeks ago • 4 comments

Closes: GLITCH-95

Description:

This PR improves dashboard and chart screenshot reliability by adding a new indicator mechanism that explicitly signals when content is ready to be captured.

The implementation adds a hidden DOM element (#lightdash-ready-indicator) that appears only when all tiles have finished loading. Each visualization component now tracks its loading state and signals when it's ready for screenshot. The backend can be configured to use this new approach via the SCHEDULER_USE_SCREENSHOT_READY_INDICATOR=true environment variable.

This approach is more reliable than the previous method which relied on waiting for loading overlays to disappear, as it provides a positive signal when content is ready rather than waiting for the absence of loading indicators.

pimmey avatar Dec 10 '25 18:12 pimmey

This stack of pull requests is managed by Graphite. Learn more about stacking.

pimmey avatar Dec 10 '25 18:12 pimmey

Your preview environment pr-18742 has been deployed.

Preview environment endpoints are available at:

github-actions[bot] avatar Dec 10 '25 18:12 github-actions[bot]

Preview Environment

🌐 URL: https://lightdash-preview-pr-18742.lightdash.okteto.dev

📋 Logs: View in GCP Console

🔧 SSH: ./scripts/okteto-ssh.sh 18742

github-actions[bot] avatar Dec 10 '25 18:12 github-actions[bot]

Nice catch!

Repro'd and fixed.

Before/After
Before After
slack-image_jaffle_dashboard_CidlScG-stMBQZeXdxE1I slack-image_jaffle_dashboard_ogoh_lFljmOZKw3g3RKyq

pimmey avatar Dec 15 '25 17:12 pimmey

:tada: This PR is included in version 0.2269.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

lightdash-bot avatar Dec 19 '25 16:12 lightdash-bot