lightdash icon indicating copy to clipboard operation
lightdash copied to clipboard

You should be able to access the "Default Colour Settings tab" from the colour picker.

Open PriPatel opened this issue 3 years ago • 7 comments

The likely journey of the user will be:

  1. User is editing a chart
  2. User wants to change colours of the chart so will open the colour picker
  3. User is not happy with default settings and wants to change them

Their immediate thought won't be to look in the Settings tab. We should allow them access to this tab from the colour picker itself.

We should add a little settings icon in the colour picker itself to direct them to the right place. ( i have nooo idea if this is even possible!) Screenshot 2022-04-01 at 10 04 59

Mockup https://www.figma.com/file/Mhuwki1Bj1akQIwPyr1gWw/Lightdash-product?node-id=2326%3A43462

PriPatel avatar Apr 01 '22 09:04 PriPatel

@PriPatel I don't think this is possible we are using this library which already gives us the block to pick it up and its not very flexible to add anything to it.

Im thinking there is 2 ways we could do this.

  1. re think a way that the user could access this within the chart config but outside the colour picker block pop up.
  2. or we could create our own colour picker component. this will though require more time.

Let me know what you decide :)

nathaliabj avatar Apr 01 '22 18:04 nathaliabj

This is interesting, how did you get the cog icon in the colorpicker ? maybe that button could trigger an event that we can capture and open the panel..

image

As @nathaliabj mentioned, that component is not very flexible

image

rephus avatar Apr 04 '22 07:04 rephus

@rephus - The first image is a mockup (I think thats what you were referring to! ignore me if not! :) )

Thanks for the alternative options @nathaliabj We have this ticket as well - https://github.com/lightdash/lightdash/issues/1579. This makes me think a new colour picker might be the way forward in order to accommodate all the things we want to do! Let's put this ticket aside for now then.

PriPatel avatar Apr 04 '22 08:04 PriPatel

Is this issue still relevant? There have been no updates for 60 days, please close the issue or keep the conversation going!

stale[bot] avatar Jun 03 '22 13:06 stale[bot]

Is this issue still relevant? There have been no updates for 60 days, please close the issue or keep the conversation going!

stale[bot] avatar Sep 06 '22 11:09 stale[bot]

This ticket is really old, not sure if it is relevant anymore. @PriPatel ?

rephus avatar Sep 12 '22 06:09 rephus

I think it will be relevant when we work on bigger chart config changes but at the moment it doesnt seem to be a problem for anyone!

PriPatel avatar Sep 12 '22 08:09 PriPatel

Is this issue still relevant? There have been no updates for 60 days, please close the issue or keep the conversation going!

stale[bot] avatar Nov 11 '22 08:11 stale[bot]

Very relevant if we want to be able to add more flexibility to colours!

PriPatel avatar Nov 11 '22 09:11 PriPatel

Is this issue still relevant? There have been no updates for 60 days, please close the issue or keep the conversation going!

stale[bot] avatar Jan 10 '23 18:01 stale[bot]