lightdash
fix: dashboard mentions not working sometimes and added loading state
Closes: https://github.com/lightdash/lightdash/issues/10666
Description:
In this pull request https://github.com/lightdash/lightdash/pull/11212, I didn't add a loading state. I created a loading component that waits for useOrganizationUsers and useSpace to resolve before displaying the CommentForm.
Reviewer actions
- [ ] I have manually tested the changes in the preview environment
- [ ] I have reviewed the code
- [ ] I understand that "request changes" will block this PR from merging
Deploy request for peaceful-bassi-cbf284 pending review.
Visit the deploys page to approve it
| Name | Link |
|---|---|
| Latest commit | 6335455fe29bcc1eb045a6bafb7899a87b3c0fd7 |
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
@anshul45 changed hook to return undefined instead of an empty array when the data was not ready. Also made the loading /skeleton just on the input so it fits nicely then there are other comments.
:tada: This PR is included in version 0.1237.4 :tada:
The release is available on:
0.1237.4- GitHub release
Your semantic-release bot :package::rocket:
