lightdash icon indicating copy to clipboard operation
lightdash copied to clipboard

feat: sql runner table fields

Open joaoviana opened this issue 1 year ago • 3 comments

Closes: #10551

Description:

  • uses new type ApiWarehouseTableFields when getting table fields
  • adds react-resizable so we can resize the table list field
  • adds TableFields component

(will add search feature on: https://github.com/lightdash/lightdash/issues/10569) (will address stable sidebar-collapsing animation on: https://github.com/lightdash/lightdash/issues/10571)

Demo:

https://github.com/lightdash/lightdash/assets/7611706/9c9ed044-7b00-493b-8545-556a957fb5c4

Reviewer actions

  • [ ] I have manually tested the changes in the preview environment
  • [ ] I have reviewed the code
  • [ ] I understand that "request changes" will block this PR from merging

joaoviana avatar Jul 01 '24 10:07 joaoviana

Deploy Preview for peaceful-bassi-cbf284 canceled.

Name Link
Latest commit 8acd8206c318c52e3f9f4676c132edd550fe7735
Latest deploy log https://app.netlify.com/sites/peaceful-bassi-cbf284/deploys/6683b7f9fcfe7f0008b4c722

netlify[bot] avatar Jul 01 '24 10:07 netlify[bot]

At the moment those fields/tables are not cached in the backend, but I imagine at some point we'll store them in postgres and add a refresh warehouse tables button.

rephus avatar Jul 01 '24 14:07 rephus

we got some errors from some warehouses

image

rephus avatar Jul 01 '24 15:07 rephus

:tada: This PR is included in version 0.1151.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

lightdash-bot avatar Jul 02 '24 09:07 lightdash-bot