dbt2looker icon indicating copy to clipboard operation
dbt2looker copied to clipboard
verified publisher icon lightdash

Add support for ephemeral models

Open PaddyAlton opened this issue 2 years ago • 2 comments

This PR fixes the dbt2looker tool such that ephemeral models do not break it (see issue #57).

It is inspired by earlier suggestions by @boludo00 and @mariana-s-fernandes , with minor modifications.

PaddyAlton avatar Jan 18 '24 17:01 PaddyAlton

Hi @owlas - just checking whether my revisions following your review got lost in the churn?

There are three small PRs in a stack:

  • https://github.com/lightdash/dbt2looker/pull/90 (this one)
  • then https://github.com/lightdash/dbt2looker/pull/92 (contains the separated tag filter change)
  • then https://github.com/lightdash/dbt2looker/pull/91 (separate work, but stacked on top because I couldn't develop locally without first solving these issues with ephemeral models and tag-based filtering)

No particular rush, but thought I'd check this was on your radar.

PaddyAlton avatar Mar 11 '24 17:03 PaddyAlton

@owlas - just a gentle nudge, any chance of merging these contributions?

PaddyAlton avatar Jul 31 '24 16:07 PaddyAlton