paradox icon indicating copy to clipboard operation
paradox copied to clipboard

Expose property for relative source path

Open justinp opened this issue 2 years ago • 2 comments

I'm using paradox from a Bitbucket repository and I'd like to make source links the way they exist for GitHub. Rather than making a specific property, I decided to try to piece the URL together from parts. The only part that I can't find a way to access is the relative path from the root of the repository to the markdown source file.

This change adds relative to Page so that, for example $page.self.relative$ can be used.

justinp avatar Sep 30 '22 22:09 justinp

At least one commit author ([email protected]) is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

lightbend-cla-validator avatar Sep 30 '22 22:09 lightbend-cla-validator

Hi @justinp,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it. Please review the new CLA and sign it before we proceed with reviewing this pull request:

https://www.lightbend.com/contribute/cla

lightbend-cla-validator avatar Sep 30 '22 22:09 lightbend-cla-validator

Looks like the CLA check is failing, as the CLA has been updated.

pvlugter avatar Oct 18 '22 04:10 pvlugter

Thanks.

I noticed the CLA thing, but I submitted it right after I opened this PR and again just now, and it still seems to appear stuck.

justinp avatar Oct 18 '22 14:10 justinp

Re-triggered the CLA check with reopening the PR. All good. Thanks.

pvlugter avatar Oct 18 '22 21:10 pvlugter

Thanks for merging it!

What's the process I need to go through to get an officially published artifact I can use?

justinp avatar Oct 20 '22 02:10 justinp

Released paradox 0.10.3 with this change.

pvlugter avatar Oct 25 '22 03:10 pvlugter