kalix-jvm-sdk icon indicating copy to clipboard operation
kalix-jvm-sdk copied to clipboard

bug: why traceparent metadata in the headers is not read as tracing.

Open franciscolopezsancho opened this issue 2 years ago • 3 comments

When calling from an action to an entity the Create should retrieve the traceparent from the headers and join both Action.InitializeCart -> Service.Create in one trace. Screenshot 2024-02-05 at 11 34 01

Metadata is added to the headers ComponentSourceGenerator.scala and from those the traceparent should be extracted.

             |        return addHeaders(((${messageType.fullyQualifiedGrpcServiceInterfaceName}Client) client).$commandMethod(), metadata).invoke($paramName);

franciscolopezsancho avatar Feb 05 '24 10:02 franciscolopezsancho

Is this different from the component to component tracing?

efgpinto avatar Feb 06 '24 10:02 efgpinto

I found it when implementing component to component in protobuf

franciscolopezsancho avatar Feb 06 '24 11:02 franciscolopezsancho

Also in Spring

franciscolopezsancho avatar Feb 16 '24 10:02 franciscolopezsancho

This doesn't apply anymore. Screenshot 2024-07-08 at 09 11 34

franciscolopezsancho avatar Jul 08 '24 07:07 franciscolopezsancho

So maybe this one is fixed as well? I even wonder if it was a duplicate.

efgpinto avatar Jul 08 '24 09:07 efgpinto

I'd say so, yes.

Removing issues and deleting code are my favorites. I'm closing that one.

franciscolopezsancho avatar Jul 16 '24 06:07 franciscolopezsancho