kalix-javascript-sdk icon indicating copy to clipboard operation
kalix-javascript-sdk copied to clipboard

Generated JS source files should be camel cased

Open mckeeh3 opened this issue 3 years ago • 2 comments

The generated JS source files created by npm run build, the file names are not camel-cased. The file names are all lowercase.

Example: service ShoppingCartVeToTopic generates shoppingcartvetotopic.js.

mckeeh3 avatar Sep 27 '21 16:09 mckeeh3

The current behavior aligns with JS conventions:

https://www.w3schools.com/js/js_conventions.asp

Use Lower Case File Names

also Google: https://google.github.io/styleguide/jsguide.html#file-name

and more independent sources:

https://newbedev.com/what-is-the-javascript-filename-naming-convention

https://stackoverflow.com/a/7273448/7898052

@mckeeh3 any specific reason to not follow the standard for JS?

andreaTP avatar Sep 27 '21 17:09 andreaTP

Ok, what about underscores or hyphens? My guess is that in the proto defs that longer compound names will be common.

mckeeh3 avatar Sep 27 '21 17:09 mckeeh3