kafka-streams-scala icon indicating copy to clipboard operation
kafka-streams-scala copied to clipboard

Published 20 hours ago • verified publisher icon lightbend

Scalish

Open ouertani opened this issue 6 years ago • 4 comments

Scala version https://github.com/ouertani/kafka-streams-scala/blob/scalish/src/main/scala/com/lightbend/kafka/scala/streams/KafkaStreamsS.scala of KafkaStreams

ouertani avatar Apr 03 '18 07:04 ouertani

Looks good to me after rebasing. Should we move forward with this @debasishg?

joan38 avatar May 03 '18 09:05 joan38

Why do we need this ? We don't want to create any unnecessary wrappers. The Java version works nicely with Scala ..

debasishg avatar May 03 '18 10:05 debasishg

@debasishg some fluent flavors has been introduced https://github.com/ouertani/kafka-streams-scala/blob/8cf1c959d00073a4b3b016fac78d1086c21eeedf/src/main/scala/com/lightbend/kafka/scala/streams/KafkaStreamsS.scala#L43

ouertani avatar May 03 '18 12:05 ouertani

Indeed some fluent syntax has been introduced which is a plus but I think what @debasishg is pointing out is: Is this added value worth enough the effort to maintain a whole wrapper?

I'm personally neutral on this but we should definitly get ride of does println()s.

joan38 avatar May 03 '18 17:05 joan38