Upgrade to work with Kafka Streams 2.0

[jurgispods]

Any plans to support compatibility with Kafka Streams 2.0?

I could submit a pull request, if you are interested. The changes are minor, but not backwards-compatible.

[jurgispods]

See https://github.com/lightbend/kafka-streams-query/pull/14

[debasishg]

Thanks! We can support Kafka 2.0 but the backwards incompatibility is a problem. Let us discuss a bit .. @blublinsky - What do u think ?

[blublinsky]

I think it makes sense

Boris Lublinsky FDP Architect [email protected] https://www.lightbend.com/

On Dec 11, 2018, at 2:18 AM, Debasish Ghosh [email protected] wrote:

Thanks! We can support Kafka 2.0 but the backwards incompatibility is a problem. Let us discuss a bit .. @blublinsky https://github.com/blublinsky - What do u think ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lightbend/kafka-streams-query/issues/13#issuecomment-446111548, or mute the thread https://github.com/notifications/unsubscribe-auth/AYHWG8RVzOQlCi_Ml-CSNn3_fJmH6y-Nks5u32pxgaJpZM4ZK3-6.

[psilos]

@debasishg @blublinsky any plans to upgrade to Kafka Streams 2.0 ?

[psilos]

@pederpansen Have you used your patch successfully, we are currently having the same issues with Serialisation and would be looking to use your fix

Exception in thread "main" java.lang.InstantiationError: org.apache.kafka.streams.kstream.internals.WindowedSerializer
	at com.lightbend.kafka.scala.iq.serializers.Serializers.$init$(Serializers.scala:20)

[debasishg]

Apologies I completely missed the thread. I will be off on vacation for the rest of the month. Can look into it once I am back. Meanwhile thanks for all the work!

[jurgispods]

@psilos Yes, we are using it in production. Would still be interested to get this merged, as we plan to expand our set of Scala-based Kafka Streams applications.

[psilos]

Apologies I completely missed the thread. I will be off on vacation for the rest of the month. Can look into it once I am back. Meanwhile thanks for all the work!

Any update on this @debasishg ? Should we just fork it and go through our own path? It seems the PR from @pederpansen is pretty much there and working as expected. I would prefer to use an official release of course, but if the project has fallen out of support it would be good to know :)

[debasishg]

I will take a look very soon. We have been traveling a lot of late and it fell off my radar. I am traveling right now and will be back Sunday. Will definitely address it next week. Apologies once again ..

On Fri, 28 Jun 2019 at 7:01 PM, Konstantinos Papalias < [email protected]> wrote:

Apologies I completely missed the thread. I will be off on vacation for the rest of the month. Can look into it once I am back. Meanwhile thanks for all the work!

Any update on this @debasishg https://github.com/debasishg ? Should we just fork it and go through our own path? It seems the PR from @pederpansen https://github.com/pederpansen is pretty much there and working as expected. I would prefer to use an official release of course, but if the project has fallen out of support it would be good to know :)

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/lightbend/kafka-streams-query/issues/13?email_source=notifications&email_token=AAA2FX3QMFVE4RW74N2KMRTP4YRVLA5CNFSM4GJLP65KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY2KIJQ#issuecomment-506766374, or mute the thread https://github.com/notifications/unsubscribe-auth/AAA2FX26FF5PC2QQBCJB7SDP4YRVLANCNFSM4GJLP65A .

-- Sent from my iPhone

[debasishg]

I took a look at the PR just now. Should we target Kafka 2.2.0 now ?

[jurgispods]

@debasishg Yes, definitely. Unfortunately, it is now my turn to be traveling, so I will not be able to update my PR until August.

[debasishg]

I will test it against Kafka 2.2 and see how it works. Just returned from a long trip ..

On Sun, 30 Jun 2019 at 1:49 PM, Jurgis Pods [email protected] wrote:

@debashig Yes, definitely. Unfortunately, it is now my turn to be traveling, so I will not be able to update my PR until August.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/lightbend/kafka-streams-query/issues/13?email_source=notifications&email_token=AAA2FXZ5ASPSP2SRBB4DCGLP5BUANA5CNFSM4GJLP65KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY4HTSI#issuecomment-507017673, or mute the thread https://github.com/notifications/unsubscribe-auth/AAA2FX42RYFTI6PXORDMVXTP5BUANANCNFSM4GJLP65A .

-- Sent from my iPhone

[jurgispods]

Hi @debasishg. I'm back from vacation and willing to support porting to Kafka 2.2. Please let me know about the current state of work.

[debasishg]

Please see my comment https://github.com/lightbend/kafka-streams-query/pull/14#issuecomment-508239946 .. looks like a non trivial task as many things have changed. I started the work but could not make much progress due to day job pressure - approaching release of our product and hence insanely busy. Will u be able to pick things up (in case u have some bandwidth) ?