config icon indicating copy to clipboard operation
config copied to clipboard

Add support for constructor handling in config beans

Open lodik opened this issue 5 years ago • 6 comments

Add support for beans, having not default constructor with annotation java.beans.ConstructorProperties. This allowing to write bean class using lombok annotation @Value instead of @Data

lodik avatar Jul 18 '19 23:07 lodik

Great PR, with this change configuration beans can be finally made immutable!

radist-nt avatar Jun 19 '20 22:06 radist-nt

@havocp Can you take a look?

lodik avatar Jul 01 '20 13:07 lodik

@havocp what can/needs to be done to get this PR merged ? At my place we try to aggressively use immutable objects to lower risk of bugs, so this would help us a lot

Gaibhne avatar Sep 29 '20 13:09 Gaibhne

@havocp @radist-nt I hate to 'ping' you like this, but it is unclear why this (almost two year old!) user contribution has not been merged or rejected. Could you please clear up what is going on or what can be done ?

Gaibhne avatar Jun 08 '21 09:06 Gaibhne

There are tons of open issues and PRs, in general I don't have time to work on them for now. Sometimes I will approve something or comment on something that's really easy but this one would take me some time to review in a meaningful way. It's possible someone at Lightbend has some time to look at it.

(larger discussion, I think the library would benefit from a couple months of focused work to catch up on all the issues and PRs but I'm not sure how to make the stars align so someone with the right knowledge has that time available.)

havocp avatar Jun 08 '21 14:06 havocp

Thanks for the response, while disappointing, it is absolutely understandable for an open source project to be lacking in resources.

Gaibhne avatar Aug 04 '21 11:08 Gaibhne

We do not intend to extend the functionality of "Typesafe Config" further. See https://github.com/lightbend/config#maintained-by

ennru avatar Jul 06 '23 08:07 ennru