smoked-salmon icon indicating copy to clipboard operation
smoked-salmon copied to clipboard

Published 20 hours ago • verified publisher icon ligh7s

Docker

Open goofus opened this issue 4 years ago • 6 comments

Run salmi in docker!

goofus avatar Mar 01 '20 12:03 goofus

Document the changes in UPGRADING.md.

LGTM otherwise. 👍

bootldrDNB avatar Mar 02 '20 11:03 bootldrDNB

modification to upgrading file not needed since this does not affect existing users at all

ligh7s avatar Mar 02 '20 14:03 ligh7s

Why not merge? 😔

AN1MATEK avatar Jul 15 '24 11:07 AN1MATEK

I'd love to help out with this! Would you be interested in merging if I opened a new PR with these proposed changes?

kieraneglin avatar Jul 23 '24 22:07 kieraneglin

I'd love to help out with this! Would you be interested in merging if I opened a new PR with these proposed changes?

Perhaps you can check out this branch: https://github.com/ghoto/smoked-salmon/tree/elghoto-version

Has quite a few improvements over this :)

backstab5983 avatar Jul 24 '24 11:07 backstab5983

@backstab5983 I made a PR here: https://github.com/ghoto/smoked-salmon/pull/2

If anyone wants to take the changes from that PR, feel free! I can also open a similar PR here if @ligh7s is interested

kieraneglin avatar Jul 24 '24 16:07 kieraneglin