Jordan Liggitt

Results 346 comments of Jordan Liggitt

> Then we should deprecate and remove it :) Deprecate, possibly, but not remove since it's GA

still flaking - https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/109048/pull-kubernetes-e2e-kind-ipv6/1507725298496442368

flaking conformance tests are concerning and should take priority over new conformance test additions

/remove-kind bug /kind support list is a distinct permission from get, and requires view access to all resources of the requested type. ACL-filtered list ("list only instances I have GET...

looks like @thockin is reviewing this

master is open for 1.26, would like to get this resolved early in the cycle (and possibly backport if the fix is minimal enough). Will you be able to address...

the integration test failures look related... I suspect the failing tests are using a different method of setting up the test server which does not go through the normal authorizer...

yeah, it looks like some integration tests are monkeying with the authorizer: ``` git grep ".Authorization.Authorizer = " -- test/integration test/integration/apiserver/flowcontrol/concurrency_util_test.go: config.GenericConfig.Authorization.Authorizer = authz test/integration/auth/accessreview_test.go: config.GenericConfig.Authorization.Authorizer = sarAuthorizer{} test/integration/auth/accessreview_test.go: config.GenericConfig.Authorization.Authorizer...

> > Previously, whatever the integration test set had the superuser authorizer prepended... now, the integration test is stomping the superuser authorizer. > > I checked by adding back the...

test fixes are merged, this should be able to rebase on master and drop the duplicate superuser authorizer now