Jordan Liggitt
Jordan Liggitt
thanks for the API review, marking API changes as approved looks like dropping the exclusion from reset_fields_test.go and making sure the test doesn't flake is the only outstanding thing for...
sounds good, can fast-follow this PR with https://github.com/kubernetes/kubernetes/pull/112575
/approve for dependency update
opened https://github.com/kubernetes/kubernetes/pull/112692 with a POC of just dumping DOT format without the library... seems to work just fine
> One potential concern is that the AssumeCache must make an assumption (sic!) about the content of the ResourceVersion field. That is a concern... I don't think we should provide...
> Out of the meeting `createAuthorizationV1SubjectAccessReview` is not optional and have no apparent reason why it could not be tested. Agreed. It should be conformance tested (and actually is already...
> Do you have thoughts on the Conformance eligibility of `createAuthorizationV1NamespacedLocalSubjectAccessReview` and `createAuthorizationV1SelfSubjectRulesReview` as noted in https://github.com/kubernetes/kubernetes/issues/112657#issuecomment-1255525962, `createAuthorizationV1NamespacedLocalSubjectAccessReview` should be eligible for conformance for the same reasons as `createAuthorizationV1SubjectAccessReview` I'm...
> Seems like we could treat createAuthorizationV1SelfSubjectRulesReview like we do the CSR API - the basic REST semantics of the API need to work but the response may have different...