Jordan Liggitt
Jordan Liggitt
API doc change lgtm /approve
lgtm, squash before merge?
> I don't see serialized `v1beta2` for `flowcontrol.apiserver.k8s.io` in testdata/v1.24.0 or testdata/v1.25.0. `v1beta2` was added in 1.23, did we miss something there? https://github.com/kubernetes/kubernetes/blob/release-1.25/staging/src/k8s.io/api/roundtrip_test.go#L52 is missing v1beta2 ... I regenerated those...
thanks for the review @cici37 API mechanics lgtm as well, just a couple cleanup nits and one question about whether any changes to defaults are desired as part of this...
I just noticed https://github.com/kubernetes/kubernetes/issues/107574 which looks like an API change queued up for the next APF version. Should that be done in this PR? Are there other changes like that...
Make the patch annotation change in this PR (in a separate commit), so it's super clear there are no clients built with the previous annotations. The field addition can happen...
changes lgtm, if the field rename mentioned in https://github.com/kubernetes/kubernetes/issues/107574#issuecomment-1249564952 is planned for v1beta3, that should happen in this PR as well