Jordan Liggitt
Jordan Liggitt
is this blocked by https://github.com/kubernetes/kubernetes/pull/100125?
https://github.com/kubernetes/kubernetes/pull/100125 / https://github.com/kubernetes/kubernetes/issues/100119 has to be resolved before we can switch kubelet to the new event recorder
https://github.com/kubernetes/kubernetes/issues/100119 is resolved in master
routing the validation change review to @deads2k since he already swept this and was involved in Job reviews around completed status recently the question about field vs label is good,...
hrmm... I thought we were using json output from tests, which spit out structured data with failure indicators. Is that just for unit tests?
I would expect us to use json format for test output, rather than ask go to add text prefixing
in your json example, we have this: > {"Time":"2023-03-10T08:19:24.59580443+01:00","Action":"fail","Package":"k8s.io/kubernetes/test","Test":"TestLog","Elapsed":0} That indicates in a structured way that the TestLog test specifically failed. Is that not enough for our analysis to treat...
>> but upgrade node for workers lacks the -f >> ... >> one quick workaround is to add the flag. > > should we add this flag and would it...
Given how long v1beta1 kubelet config has been around, supporting it in parallel with any eventual v1 config file for several releases (maybe 4 so n-3 would work) would seem...
> @liggitt Am I reading it wrong? shouldn't this codec generate defaults? It applies defaults it knows about, which are defaulting functions registered into the codec. Whether defaulting functions are...