Jordan Liggitt

Results 346 comments of Jordan Liggitt

> for downstream consumers will be more tricky, we will communicate the change but not sure how to deal with that It's important to understand the scope of that impact...

@rhockenbury the KEP is merged. Can you verify this is in good shape for 1.24?

> Would y'all like to have this included in the deprecations and removal blog for 1.24? no, this doesn't modify any existing beta APIs, it is strictly for future beta...

/assign (from 12/6 Steering public meeting)

https://github.com/golang/exp/blob/master/apidiff might be a possibility as well

sample verify script with API package compatibility checks here: https://github.com/liggitt/kubernetes/commits/apidiff-master comparison of master against 1.14 and 1.15: ``` k8s.io/apimachinery ========== v1.14.0 ===== pkg.api.meta: - List.GetRemainingItemCount: added - List.SetRemainingItemCount: added pkg.apis.meta.v1:...

> Is it convention to run a go get -u on the client-go repo? no, upgrading to HEAD of all dependencies of client-go is not expected to work as long...

thanks for the update, looks good. one nit from CI on the yaml file and one request for any links to the sig updates you have

verify error: ``` go run ./generator/app.go Validating sigs.yaml ERROR: wg-multitenancy: emeritus leads should not have company specified; company specified for: Sanjeev Rampal exit status 1 ``` needs this change: ```diff...