Jordan Liggitt
Jordan Liggitt
> Do you think the PR #83032 can be reviewed with the above open question? We can queue up a review for it. @thockin / @smarterclayton, either of you available...
API change lgtm /hold for node approval
It was an unrelated failure now resolved in master /retest
/assign @tallclair can you take a look?
this also intersects with validation improvements being made to ValidateLabelSelector in https://github.com/kubernetes/kubernetes/pull/107531 ... we may want to merge that first
changes from https://github.com/kubernetes/kubernetes/pull/107531 are merged in https://github.com/kubernetes/kubernetes/pull/113699 this can be rebased and use the AllowInvalidTopologySpreadConstraintLabelSelector option to populate the AllowInvalidLabelValueInSelector option when calling ValidateLabelSelector
this lgtm, just a couple comments /milestone v1.27