Jordan Liggitt

Results 346 comments of Jordan Liggitt

> This seems like a chicken-egg problem. I can't add the rules in a separate PR because `hack/verify-publishing-bot.py` checks everything in staging dir has a publishing rule. If I add...

> gotcha! let me try that. The staging repo has been created with default branch `main`. Do we need to change that until the script is modified and all existing...

replicate the content of staging/src/k8s.io/apiserver/pkg/storage/value/encrypt/envelope/kmsv2/v2alpha1/OWNERS to staging/src/k8s.io/kms/apis/OWNERS to make sure these packages show up as packages needing API review lgtm otherwise (once the publishing bot CI is green)

> @liggitt publishing bot CI failure is because there is no `kms` directory in the k/k master branch? > > ```shell > I0923 16:09:47.572947 152 validate.go:37] validating directories exist in...

> `TestWatchDeleteEventObjectHaveLatestRV` uses the etcd client to: > * create a raw watch, we check that the mod revision at which the raw watch shows us the delete is the...

I'm not aware of a restriction, and I'm not able to recreate the issue... ```yaml apiVersion: apiextensions.k8s.io/v1 kind: CustomResourceDefinition metadata: name: xlists.example.com spec: group: example.com scope: Namespaced versions: - name:...

@kubernetes/sig-architecture-api-reviews @kubernetes/sig-api-machinery-api-reviews

cc @kubernetes/api-approvers @kubernetes/api-reviewers /assign