WebOptimizer icon indicating copy to clipboard operation
WebOptimizer copied to clipboard

change to concurrent dictionary

Open jasonliao-cb opened this issue 2 years ago • 2 comments

jasonliao-cb avatar Apr 11 '22 06:04 jasonliao-cb

this is for issue https://github.com/ligershark/WebOptimizer/issues/228

jasonliao-cb avatar Apr 11 '22 06:04 jasonliao-cb

I was able to replicate similar issues by running parallel tasks racing to make the first request to GenerateCacheKey on a single instance of Asset. With the change above, I am able to run parallel tasks without issue.

With the tests I created, I was getting NullReferenceException on the code: asset.Items[PhysicalFilesKey] = files;

daneSchilling avatar Jun 15 '22 16:06 daneSchilling

@jasonliao-cb I would love for this to get merged. Maybe add the author as the reviewer? They may ask you to remove the unrelated gitignore changes. Thanks again for opening the PR!

daneSchilling avatar Aug 30 '22 12:08 daneSchilling

Thanks

madskristensen avatar Aug 30 '22 14:08 madskristensen

Thank you!

daneSchilling avatar Aug 30 '22 14:08 daneSchilling

@madskristensen Can you publish the latest version?

exileDev avatar Sep 28 '22 14:09 exileDev

Yes, releasing now...

madskristensen avatar Sep 28 '22 16:09 madskristensen