framework icon indicating copy to clipboard operation
framework copied to clipboard

Published 20 hours ago • verified publisher icon lift

Remove deprecated JS stuff

Open mariusdanciu opened this issue 14 years ago • 7 comments

Remove the following deprecations:

  1. JQueryLeft, JQueryRight
  2. JSRules.fadeTime, JsRules.prefadeDuration as we have the generic auto fadeout mechanism
  3. Remove JqSHtml as all things are deprecated here.

mariusdanciu avatar May 17 '10 03:05 mariusdanciu

changed milestone to none

mariusdanciu avatar Aug 24 '10 23:08 mariusdanciu

Imported from Assembla: http://www.assembla.com/spaces/liftweb/tickets/526

github-importer avatar Feb 19 '12 21:02 github-importer

I'll take this guy after #1534 goes in.

Shadowfiend avatar May 10 '14 14:05 Shadowfiend

Remove JqSHtml as all things are deprecated here.

Removed this.

JQueryLeft, JQueryRight

Can't find these.

JSRules.fadeTime, JsRules.prefadeDuration as we have the generic auto fadeout mechanism

The deprecated warning has been commented out on these...

farmdawgnation avatar Oct 27 '15 23:10 farmdawgnation

It looks like the commented out deprecation warning on fadeTime and prefadeDuration was done by @fmpwizard in 48051bd79d43f802e7c6b628729513e0545d66f9 – any chance you remember why Diego?

farmdawgnation avatar Oct 27 '15 23:10 farmdawgnation

@farmdawgnation I stand innocent :) that commit was to revert a previous commit, and then I went back through the history of that file and the first commit that commented out the deprecated message was

https://github.com/lift/framework/commit/23bfc86a1619fe012b34c555b5757f65d956ee07#diff-d9a7c49760f4ebf04fe82c7f9c5f7797

I would assume it wasn't meant to be permanent but maybe @dpp has more info

fmpwizard avatar Oct 28 '15 00:10 fmpwizard

Bleh, looks like we missed this guy so I think I'm going to drop the milestone since removing it will have to wait.

Shadowfiend avatar Nov 16 '16 23:11 Shadowfiend