typeahead-bundle
typeahead-bundle copied to clipboard
lifo101
Add Symfony 5 compatibility
Changes in the configuration loader will add support for Symfony 5. Of course this might be breaking for other versions so it must be a new major version.
Correct, solved it. It needs extensive testing, something that I haven't done at the moment.
Btw, don't merge this yet as I will add more changes most likely once I get a project migrated.
@lifo101 I got it working in Symfony 5 right now. It still needs testing in different 4.x versions and < 4.0 versions. It would be nice if you could help with that maybe, and give maybe additional feedback. I had to remove several things from the template like spaceless filter (as it's now implemented differently in twig, but unable to apply this due to backward compatibility reasons). And I had to undo the nested for .. if clause as it's now working with filters in the new Twig versions.
@lifo101 thank you very much for typeahead-bundle, have used it lots over the years. Looking forward to https://github.com/lifo101/autocomplete-bundle , will definitely check it out as soon as you have tagged a release. In the mean time it would be great to eek a little bit more out of typeahead-bundle with this PR if it works. @tomvlk great work, I'd be more than happy to test this on a SF4 build with diverse uses of TypeaheadType.
Any feedback as soon as would be appreciated, as working on an SF4 upgrade right now and having to decide wether to rip out typeahead or not.
I won't be able to do much with this due to the holidays and vacation until after the new year.
Just for feedback, I've now got this branch deployed in production environments as it working well in Symfony 4.4
Would be nice if this can get into the official release soon. Thanks all for the work on the repository.