Update solc and evm version

[0xDEnYO]

Which Jira task belongs to this PR?

Why did I implement it this way?

We used to have typescript and other compatibility issues when running our codebase on higher solidity version but that seems to have changed now. Our auditor (Sujith) has confirmed that changing to newer solc and evm version does not impose a security risk.

Checklist before requesting a review

• [ ] I have performed a self-review of my code
• [ ] This pull request is as small as possible and only tackles one problem
• [ ] I have added tests that cover the functionality / test the bug
• [ ] For new facets: I have checked all points from this list: https://www.notion.so/lifi/New-Facet-Contract-Checklist-157f0ff14ac78095a2b8f999d655622e
• [ ] I have updated any required documentation

Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)

• [ ] I have checked that any arbitrary calls to external contracts are validated and or restricted
• [ ] I have checked that any privileged calls (i.e. storage modifications) are validated and or restricted
• [ ] I have ensured that any new contracts have had AT A MINIMUM 1 preliminary audit conducted on by <company/auditor>

[coderabbitai[bot]]

[!WARNING]

Rate limit exceeded

@mirooon has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 40 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 4a986a597523d9889c1eb011757d0dcfedf1d73e and b72799c7be41cccbcfb60bc46b7e6ae88659f729.

📒 Files selected for processing (1)

• script/removeDuplicateEventsFromABI.ts (1 hunks)

Walkthrough

This set of changes updates the Solidity development environment and test infrastructure. The Solidity compiler and EVM versions are bumped in configuration files and scripts, moving from version 0.8.17/Shanghai to 0.8.29/Cancun. New build scripts are introduced to remove duplicate events from ABI files before generating TypeScript types, preventing type conflicts. Test contracts are refactored for improved readability and safety, including the addition of a custom memory-safe slicing function and error handling in one test contract. Workflow scripts are updated to align with the new EVM version.

Changes

File(s)	Change Summary
foundry.toml	Updated solc_version from 0.8.17 to 0.8.29 and evm_version from shanghai to cancun. No other settings changed.
package.json	Updated test and coverage scripts to use EVM version 'cancun'. Added abi:removeDuplicateEvents script to remove duplicate events from ABI files. Modified typechain script to run this new script before type generation.
.github/workflows/enforceTestCoverage.yml	Removed explicit --evm-version 'shanghai' from the forge coverage command in the workflow.
script/removeDuplicateEventsFromABI.ts	Added a new script to remove duplicate event definitions from specified ABI files before typechain type generation. Implements logic to filter duplicates and updates files in place.
test/solidity/Facets/CBridgeAndFeeCollection.t.sol	Refactored test to assign swap call data to local variables before constructing swap data objects, improving readability. No logic changes.
test/solidity/Facets/CalldataVerificationFacet.t.sol	Added a new SliceOutOfBounds error and a private _safeSlice function for memory-safe byte slicing. Updated a test to use this new function instead of LibBytes.slice. Improved error handling and safety in test slicing logic.

Suggested reviewers

• ezynda3

✨ Finishing Touches

• [ ] 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[lifi-action-bot]

Test Coverage Report

Line Coverage: 81.90% (2196 / 2681 lines) Function Coverage: 88.00% ( 374 / 425 functions) Branch Coverage: 49.90% ( 266 / 533 branches) Test coverage (81.90%) is above min threshold (76%). Check passed.