Deprecate LiFuelFeeCollector [CalldataVerificationFacet v1.3.0]

[0xDEnYO]

Which Jira task belongs to this PR?

https://lifi.atlassian.net/browse/LF-12384

Why did I implement it this way?

Checklist before requesting a review

• [x] I have performed a self-review of my code
• [x] This pull request is as small as possible and only tackles one problem
• [ ] I have added tests that cover the functionality / test the bug
• [ ] For new facets: I have checked all points from this list: https://www.notion.so/lifi/New-Facet-Contract-Checklist-157f0ff14ac78095a2b8f999d655622e
• [ ] I have updated any required documentation

Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)

• [ ] I have checked that any arbitrary calls to external contracts are validated and or restricted
• [ ] I have checked that any privileged calls (i.e. storage modifications) are validated and or restricted
• [ ] I have ensured that any new contracts have had AT A MINIMUM 1 preliminary audit conducted on by <company/auditor>

[coderabbitai[bot]]

Walkthrough

This pull request removes all references to the LiFuelFeeCollector contract across configuration and deployment files. The changes update the whitelist variable in a shell script, eliminate an ownership check from the health check script, and remove the corresponding JSON configuration. In addition, a lint suppression comment is added to a Solidity contract function, the quotes formatting is adjusted in the Solhint configuration, and a new directory is added to the Solhint ignore list.

Changes

File(s)	Change Summary
script/config.example.sh, script/deploy/healthCheck.ts, script/deploy/resources/deployRequirements.json	Removed LiFuelFeeCollector from the whitelist variable, its ownership check in the health check script, and its configuration in the JSON deployment requirements.
src/Facets/CalldataVerificationFacet.sol, .solhint.json, .solhintignore	Added a linting comment for gas-custom-errors, updated quotes formatting in the Solhint config, and added an archive/ entry to the Solhint ignore file.

Possibly related PRs

• lifinance/contracts#907: The changes in the main PR, which involve the removal of the LiFuelFeeCollector from the whitelist, are related to the retrieved PR as both involve modifications to the healthCheck.ts script concerning the LiFuelFeeCollector, specifically its ownership checks.
• lifinance/contracts#950: The changes in the main PR, which involve the removal of the LiFuelFeeCollector from the WHITELIST_PERIPHERY variable, are related to the retrieved PR as it also removes references to LiFuelFeeCollector, specifically in the ownership check and configuration files.
• lifinance/contracts#837: The changes in the main PR, which involve the removal of the LiFuelFeeCollector from the whitelist and related checks, are directly related to the modifications in the retrieved PR that also involve the deprecation of the LiFuelFeeCollector contract and its associated scripts.

Suggested labels

AuditNotRequired

Suggested reviewers

• ezynda3
• mirooon

[!WARNING]

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

• JIRA integration encountered authorization issues. Please disconnect and reconnect the integration in the CodeRabbit UI.

---

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1bcc34ea159e74c9acfc446a3421967f35c88c2e and 0ba235bcba56c90a7fe1edbe83f3367a72662712.

📒 Files selected for processing (4)

• .solhint.json (1 hunks)
• .solhintignore (1 hunks)
• script/deploy/healthCheck.ts (0 hunks)
• script/deploy/resources/deployRequirements.json (0 hunks)

💤 Files with no reviewable changes (2)

• script/deploy/healthCheck.ts
• script/deploy/resources/deployRequirements.json

🚧 Files skipped from review as they are similar to previous changes (2)

• .solhintignore
• .solhint.json

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: enforce-min-test-coverage
• GitHub Check: run-unit-tests
• GitHub Check: generate-tag

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[0xDEnYO]

This PR is depends on PR(#999) and should only be reviewed/merged after #999 is merged

[lifi-action-bot]

Test Coverage Report

Line Coverage: 78.43% (2026 / 2583 lines) Function Coverage: 83.57% ( 351 / 420 functions) Branch Coverage: 45.45% ( 230 / 506 branches) Test coverage (78.43%) is above min threshold (76%). Check passed.