Update CalldataVerificationFacet [CalldataVerificationFacet v1.3.0]

[0xDEnYO]

Which Jira task belongs to this PR?

Why did I implement it this way?

Checklist before requesting a review

• [x] I have performed a self-review of my code
• [x] This pull request is as small as possible and only tackles one problem
• [ ] I have added tests that cover the functionality / test the bug
• [ ] For new facets: I have checked all points from this list: https://www.notion.so/lifi/New-Facet-Contract-Checklist-157f0ff14ac78095a2b8f999d655622e
• [ ] I have updated any required documentation

Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)

• [ ] I have checked that any arbitrary calls to external contracts are validated and or restricted
• [ ] I have checked that any privileged calls (i.e. storage modifications) are validated and or restricted
• [ ] I have ensured that any new contracts have had AT A MINIMUM 1 preliminary audit conducted on by <company/auditor>

[coderabbitai[bot]]

Walkthrough

The pull request updates the version number and refactors the calldata handling logic in the CalldataVerificationFacet contract and its tests. It removes the dependency on the StandardizedCallFacet by eliminating related import statements and conditional checks. Functions for extracting swap and bridge data have been simplified accordingly. Test cases have been adjusted to remove references to the obsolete facet, thus streamlining both contract functionality and associated tests.

Changes

File(s)	Change Summary
src/Facets/CalldataVerificationFacet.sol	- Updated version from 1.2.0 to 1.3.0. - Removed unused imports for AmarokFacet, StargateFacet, and StandardizedCallFacet. - Simplified calldata extraction functions by eliminating StandardizedCallFacet checks.
test/solidity/Facets/CalldataVerificationFacet.t.sol	- Removed import for StandardizedCallFacet. - Deleted test cases and code segments that created standardizedCallData using the StandardizedCallFacet selector, simplifying tests.
audit/auditLog.json	- Added new audit entry "audit20250220" and updated the CalldataVerificationFacet entry to include version 1.3.0 referencing this audit.

Possibly related PRs

• lifinance/contracts#768: The changes in the main PR focus on removing dependencies on StandardizedCallFacet in the CalldataVerificationFacet contract and its tests, while the retrieved PR modifies the CalldataVerificationFacet contract to enhance its functionality for handling different types of swap calls, including checks for StandardizedCallFacet, indicating a direct relationship in their modifications to the same contract.
• lifinance/contracts#767: The changes in the main PR are related to the removal of StandardizedCallFacet handling in the CalldataVerificationFacet, which aligns with the modifications in the retrieved PR that also involve the CalldataVerificationFacet and its tests.

Suggested labels

AuditCompleted

Suggested reviewers

• ezynda3
• maxklenk

[!WARNING]

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

• JIRA integration encountered authorization issues. Please disconnect and reconnect the integration in the CodeRabbit UI.

---

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5f7046676491bf0f2f94d0c88d2437fda907ec9d and 2115b1bfbebc136fe56d4f7fbad2a9566d6dc121.

📒 Files selected for processing (1)

• audit/auditLog.json (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• audit/auditLog.json

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: enforce-min-test-coverage
• GitHub Check: run-unit-tests
• GitHub Check: generate-tag

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[lifi-action-bot]

Test Coverage Report

Line Coverage: 80.06% (2241 / 2799 lines) Function Coverage: 85.80% ( 393 / 458 functions) Branch Coverage: 44.60% ( 244 / 547 branches) Test coverage (80.06%) is above min threshold (76%). Check passed.

[github-advanced-security[bot]]

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.