liferay-frontend-projects
liferay-frontend-projects copied to clipboard
liferay
Upgrade node-bourbon
Issue type (mark with x)
- [ ] :thinking: Question
- [x ] :bug: Bug report
- [ ] :gift: Feature request
- [ ] :woman_shrugging: Other
Description
Current behavior: could you update the dependency [email protected] which is 8 years old? And the build returns an error
Where's that? Type of project? Steps to reproduce? Is it a theme? :thinking:
We have a theme on LFR 7.3 and want to upgrade it to LFR 7.4. we proceed according to the instructions and we get this warning during the build.
https://learn.liferay.com/w/dxp/site-building/site-appearance/themes/upgrading-a-theme
Old Package there use this npm package https://www.npmjs.com/package/node-bourbon?activeTab=dependencies
command
$ npm run build
package.json
{
"name": "xxxx-theme",
"version": "1.0.0",
"main": "package.json",
"keywords": [
"liferay-theme"
],
"liferayTheme": {
"baseTheme": "styled",
"fontAwesome": false,
"screenshot": "",
"templateLanguage": "ftl",
"version": "7.4"
},
"dependencies": {
"gulp-include": "2.4.1",
"gulp-uglify": "3.0.2",
"@liferay/bs3-bs4-compat": "*"
},
"devDependencies": {
"compass-mixins": "0.12.10",
"gulp": "4.0.2",
"gulp-include": "2.4.1",
"gulp-uglify": "3.0.2",
"liferay-frontend-theme-styled": "6.0.54",
"liferay-frontend-theme-unstyled": "6.0.45",
"liferay-theme-tasks": "^11.5.3",
"liferay-frontend-css-common": "6.0.8"
},
"scripts": {
"init": "gulp init",
"build": "gulp build",
"deploy": "gulp deploy",
"extend": "gulp extend",
"kickstart": "gulp kickstart",
"status": "gulp status",
"upgrade": "gulp upgrade",
"watch": "gulp watch"
}
}
Dependecies list
$ npm list --depth=1
+-- @liferay/[email protected]
+-- [email protected]
+-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| `-- [email protected]
+-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| `-- [email protected]
+-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| `-- [email protected] deduped
+-- [email protected]
+-- [email protected]
+-- [email protected]
`-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected] deduped
+-- [email protected]
+-- [email protected]
+-- [email protected] deduped
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected] deduped
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected] deduped
+-- [email protected]
+-- [email protected]
`-- [email protected]
Oh, I see, so it's coming from liferay-theme-tasks not the theme itself...
However, I think it pulls it because it is used in DXP itself, not because the tool does something with it internally, so I cannot give you an answer.
@ethib137 is this something that can be updated or does it depend on DXP's target version? :thinking:
@pat270 could you answer this? I think you know the context on this one, right?
Bourbon is a dependency of "liferay-frontend-css-common": "6.0.8". It contains our deprecated media query mixins from 6.2-7.0? I'm not exactly sure on the exact versions. You can remove that dependency in your package.json.
