electric icon indicating copy to clipboard operation
electric copied to clipboard

Make folders name configurable

Open fernandosouza opened this issue 7 years ago • 5 comments

GS team in Brazil would like to use Electric JS as a Liferay Theme Boilerplate but the style folder is incompatible with. What if Electric have it configurable?

fernandosouza avatar Jun 16 '17 16:06 fernandosouza

Should be simple to make it configurable, but what do you mean by use electric as a theme boilerplate?

robframpton avatar Jun 16 '17 17:06 robframpton

From what I understood, they would like to use ElectricJS as a starter for new projects.

cc/ @clovisdasilvaneto, @jordanamorais

fernandosouza avatar Jun 16 '17 17:06 fernandosouza

Hi @Robert-Frampton,

We would like to use electric to generate an initial styleguide for our GS themes, it will bring more value for the deliveries of the designs.

I've already managed to integrate the electric with liferay theme, but I've noticed that I have to put my SCSS files on 'styles' folder, but I'd like to change it to 'css' folder, because it is the default name of the liferay theme, is that possible?

clovisdasilvaneto avatar Jun 16 '17 18:06 clovisdasilvaneto

Hey @clovisdasilvaneto, not currently, but it would be really easy to implement. All we need is to add an option to https://github.com/electricjs/electric/blob/master/lib/options.js called scssSrc with a default value, and then implement that option in https://github.com/electricjs/electric/blob/master/lib/tasks/styles.js.

I might not have time today to do this, but feel free to send a pr :)

robframpton avatar Jun 16 '17 18:06 robframpton

That sounds like good, I'll do that 😄 😃

clovisdasilvaneto avatar Jun 16 '17 21:06 clovisdasilvaneto