clay icon indicating copy to clipboard operation
clay copied to clipboard
verified publisher icon liferay

fix(@clayui/form): LPD-36696 DualListBox adds children and don't disable left right buttons if no items are selected

Open pat270 opened this issue 1 year ago • 2 comments

https://liferay.atlassian.net/browse/LPD-36696

I added children to the component so we can pass in things like an error message. I also removed disabling the move buttons if length is 0.

duallistbox-new

pat270 avatar Sep 23 '24 21:09 pat270

Just an update on this, I spoke to Patrick and will get to work on it, should have something this week.

matuzalemsteles avatar Oct 15 '24 17:10 matuzalemsteles

I'm moving the entire validation system to the component as well as the error message with translation support, also adding new APIs to configure the maximum number of items for both sides.

matuzalemsteles avatar Oct 18 '24 23:10 matuzalemsteles

Hey @pat270 What do you think of these changes? Is this a rule that can be applied to all cases?

matuzalemsteles avatar Oct 25 '24 00:10 matuzalemsteles

@matuzalemsteles It's not working correctly for me for some reason. Here is a gif of what I'm seeing. duallistbox

pat270 avatar Oct 30 '24 20:10 pat270

@matuzalemsteles I got it to work. Some of the left/right error stuff just needed to be swapped.

pat270 avatar Oct 31 '24 20:10 pat270