graphql-resolvers-xray-tracing icon indicating copy to clipboard operation
graphql-resolvers-xray-tracing copied to clipboard

Circular structure on error

Open andyrichardson opened this issue 3 years ago • 2 comments

Hey there! First off, a huge thanks for authoring this, it's incredibly useful!

Unfortunately there is an issue with x-ray where data (errors, annotations, etc) cannot be properly serialized if they have a circular structure which leaves a potential for runtime crashes depending on the error.

Is it possible to get a release out of this which serializes the errors?

andyrichardson avatar Dec 07 '20 11:12 andyrichardson

Thank you for using the library and providing a a pull request to make it better.

I haven't seen this type of circular error problem when sending errors to X-Ray, but I know that I have some errors with circular errors in our system. Do you know the source of the circular error?

mdlavin avatar Dec 07 '20 14:12 mdlavin

Do you know the source of the circular error?

Sorry for the late response @mdlavin - I never got around to finding the source in the aws-xray source code. I know that we haven't seen it since adding this serialisation step

andyrichardson avatar Feb 26 '21 12:02 andyrichardson