Fix --config handling and allow --append-config

Open thejcannon opened this issue 5 years ago • 4 comments

From my testing, passing --config ./file.toml wasn't being handled correctly. Debugging it, it looks like parse_preliminary_options in flake8 strips out these options, so by the time we get to it in parse_configuration_and_cli they are nowhere to be found in argv.

Aug 25 '20 13:08 thejcannon

@orsinium this is good to be reviewed

Sep 11 '20 16:09 thejcannon

I tested the --config option and it now seems to work with this patch.

Jan 11 '21 12:01 sscherfke

Thank you for your contribution! Sorry for postponing the review of the PR. I'm still not sure what PR does, how it fixes the issue. Probably, I should try to debug it myself as well.

Jan 11 '21 16:01 orsinium

W/o this patch, the --config option (and probaply the --apend-config option as well) does not work since it's stripped away by flake8 before flakehell has a chance to see it.

Jan 11 '21 16:01 sscherfke