dkim_verifier icon indicating copy to clipboard operation
dkim_verifier copied to clipboard

Backport feature detailed results 5 to 2x

Open dodmi opened this issue 1 year ago • 2 comments

I'm creating a pull request for my backport of displaying detailed results. So you can see the code matching the screenshots.

I'm pretty happy with the output, now. But I'm unhappy, how I solved the GUI part in chrome/content/dkim.js. I don't really understand your code in bindings.xml (or custom XUL elements in general). So my implementation is pretty ugly and probably needs some improvement. The clean way would probably be extending bindings.xml and not manipulating DOM objects directly...

dodmi avatar May 30 '24 19:05 dodmi

Thanks for back porting this work in progress. I will try to find time this weekend to continue the work on this for 5.x, and also more closely look at your back port.

lieser avatar Jul 25 '24 19:07 lieser

Feel free to use parts of my code or let me know if I should change/improve something. I thought making a pull request helps you more than my screenshots...

I'm pretty happy, but I have no solution for cut tooltips. But this isn't a problem for one or two signatures, which is the usual amount, as I can easily see now :)

dodmi avatar Jul 27 '24 10:07 dodmi

I don't plan to change anything at the moment unless I broke something while merging the other commits. But the only thing, which shared code was the PR to prefer ED25519 over RSA, which is still working fine.

So please merge the PR, this will make further changes easier.

dodmi avatar Jan 05 '25 16:01 dodmi