ethereum-validators-monitoring icon indicating copy to clipboard operation
ethereum-validators-monitoring copied to clipboard

Published 20 hours ago • verified publisher icon lidofinance

Support changing Effective Balance by config.

Open rootwarp opened this issue 1 year ago • 3 comments

Support changing Effective Balance which is fixed to 32. This feature could be useful for testnet and devnet.

rootwarp avatar Dec 12 '23 09:12 rootwarp

Ah, sorry my bad. I leaved lack of information of this PR. This PR is intended to changing MAX_EFFECTIVE_BALANCE which is fixed as 32ETH.

rootwarp avatar Dec 13 '23 07:12 rootwarp

Ah, sorry my bad. I leaved lack of information of this PR. This PR is intended to changing MAX_EFFECTIVE_BALANCE which is fixed as 32ETH.

Ah. Okay! Anyway, I would leave REFERENCE_EFFECTIVE_BALANCE_INCREMENTS because we use this var for calculating perfect attestation reward to calculate missing reward value for monitored validators. So, this reference value might not equal MAX_EFFECTIVE_BALANCE.

For example, the chain has 256 ETH as MAX_EFFECTIVE_BALANCE, but I know that the target effective balance of my monitored validators is 64 ETH, so I would like to set REFERENCE_EFFECTIVE_BALANCE_INCREMENTS=64 to use that as a reference to calculate perfect attestation for me.

Also, we can rethink this model altogether and use not some strict value, but the actual effective balance of the validator to calculate the ideal attestation for it because it can be completely different for each other after that EIP.

I would suggest postponing this PR until we don't have EIP implementation details. What do you think?

vgorkavenko avatar Dec 14 '23 06:12 vgorkavenko

Ah, sorry my bad. I leaved lack of information of this PR. This PR is intended to changing MAX_EFFECTIVE_BALANCE which is fixed as 32ETH.

Ah. Okay! Anyway, I would leave REFERENCE_EFFECTIVE_BALANCE_INCREMENTS because we use this var for calculating perfect attestation reward to calculate missing reward value for monitored validators. So, this reference value might not equal MAX_EFFECTIVE_BALANCE.

For example, the chain has 256 ETH as MAX_EFFECTIVE_BALANCE, but I know that the target effective balance of my monitored validators is 64 ETH, so I would like to set REFERENCE_EFFECTIVE_BALANCE_INCREMENTS=64 to use that as a reference to calculate perfect attestation for me.

Also, we can rethink this model altogether and use not some strict value, but the actual effective balance of the validator to calculate the ideal attestation for it because it can be completely different for each other after that EIP.

I would suggest postponing this PR until we don't have EIP implementation details. What do you think?

👍 I got your intention and I also agree with you. it will be absolutely better to proceed this PR after we get more details about the EIP.

Thanks. :)

rootwarp avatar Dec 14 '23 06:12 rootwarp