docs icon indicating copy to clipboard operation
docs copied to clipboard

Lido V2: initial doc rework

Open TheDZhon opened this issue 1 year ago • 3 comments

  • [x] Rename contracts #212
  • [x] Update sidebar #212
  • [x] Remove stETH/ETH deprecated price oracle mentions #212
  • [x] Remove 'withdrawals aren't available yet claims' and include withdrawals support feature here and there as a part of the protocol #212
  • [x] Update contents for contracts
    • [x] LidoLocator (@folkyatina) #243
    • [x] Lido (@folkyatina) #219
    • [x] EIP712StETH (@TheDZhon) #233
    • [x] AccountingOracle (@loga4) #232
    • [x] ValidatorsExitBusOracle (@loga4) #232
    • [x] HashConsensus (@loga4) #232
    • [x] LegacyOracle (@TheDZhon) #234
    • [x] OracleReportSanityChecker (@Psirex) #225
    • [x] OracleDaemonConfig #218
    • [x] StakingRouter (@mymphe) #230
    • [x] WithdrawalQueueERC712 (@folkyatina) #221
    • [x] WithdrawalVault (@folkyatina) #221
    • [x] WstETH (@folkyatina) #242
    • [x] DepositSecurityModule (@arwer13) #229
    • [x] Burner (@arwer13) #220
    • [x] LidoExecutionLayerRewardsVault #212
    • [x] GateSeal #212
    • [x] NodeOperatorsRegistry (@arwer13) #251
  • [ ] Update contents for guides
    • [ ] remove stETH superuser functions (@TheDZhon) #238
    • [ ] Protocol levers (@TheDZhon) #238
    • [ ] Roles roster (@TheDZhon) #238
  • [ ] Update any other mentions
    • [ ] TBA
  • [ ] Verify deployment branches and addresses (@arwer13)
  • [x] Remove Terra mentions :new_moon_with_face: #212
  • [x] Remove Rinkeby, Kovan, and Ropsten deployments (testnets are discontinued) #212
  • [ ] final clean-up (unify parameters as lists?, ...?)

TheDZhon avatar Jun 20 '23 07:06 TheDZhon

One discrepancy nice to unify is "Callable only by owner" and "Reverts if msg.sender is not owner", wdyt?

arwer13 avatar Jun 27 '23 12:06 arwer13

One discrepancy nice to unify is "Callable only by owner" and "Reverts if msg.sender is not owner", wdyt?

TBH, not really get the context.

folkyatina avatar Jun 27 '23 14:06 folkyatina

There are places with (1): Only callable by the owner. and (2):

:::note
Reverts if any of the following is true:
* `msg.sender` is not the owner;

I would prefer to leave only the line in reverts section.

UPD: ok, there were only Burner and DSM with "only callable...". Its replaced to option (1) in Burner already, so I would prefer even more to use (2) in DSM.

arwer13 avatar Jun 29 '23 17:06 arwer13