Marcin Rataj

Results 1311 comments of Marcin Rataj

Ok, so TLDR on technical side, found potential reason for regression: - When `Provide.DHT.SweepEnabled=true` (the default since v0.39), the `SweepingProviderOpt` function is used. It checks for DHT availability. For custom...

Turns out fix was not that complex (use Legacy provider when no DHT is present), added regression test as well, see: - https://github.com/ipfs/kubo/pull/11112 - https://github.com/ipfs/kubo/pull/11111

This is because this problem is specific to MS Windows. Ref. https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file: ``` The following reserved characters: < (less than) > (greater than) : (colon) " (double quote) / (forward...

Ah, indeed. Tracked down the Windows-specific sanitization, it is in go-libipfs/tar (`ipfs get` RPC uses TAR behind the scenes): https://github.com/ipfs/go-libipfs/blob/302b2799386dea7afb72ba0b4c32a5c427215d06/tar/sanitize_windows.go#L12 Just like others noted the `[` and `]` are allowed...

@Hazematman you could also use `~/.ipfs/api` (`$IPFS_PATH/api`) in `PathExists` it is the address of RPC API `ipfs p2p` CLI will use to connect to the daemon. could be more appropriate....

Thank you @Hazematman, there was indeed a race condition related to creation of `$IPFS_PATH/api` file. Pushed fix in 80b703a7339c80e7c6890e831f76789a734e2fbb, try the latest version of this PR if it makes any...

We could clean this up and return correct `Content-Type` here to improve UX, but not critical: - While `/api/v0/get` is how files+directories can be deserialized by third-party applications - .....

Perfored internal smoke-test with `ipfs/kubo:master-2025-06-17-eb6cc02` on Shipyar's staging gateway and collab cluster boxes ([internal notes](https://www.notion.so/Kubo-0-35-vs-0-36-2161def3428780b4aacbe92f21f03449?source=copy_link#2161def34287807c937de633310b8556)). Found cosmetic ERROR logs: - https://github.com/ipfs/boxo/issues/954 - https://github.com/ipfs/boxo/issues/955 - https://github.com/libp2p/go-libp2p-kad-dht/issues/1001 but no red flags since...

# ✅ Release Checklist (v0.36.0-rc1) ### 1. Prepare release branch - [x] Prepare the release branch and update version numbers accordingly - [x] create a new branch `release-vX.Y.Z` - use...

[Kubo v0.36.0-rc2 is out!](https://discuss.ipfs.tech/t/kubo-v0-36-0-rc1-is-out/19424?u=lidel) Early testers ping for RC1 testing: - [ ] Charity Engine (@rytiss, @tristanolive) - [ ] Fission (@bmann) - [ ] Infura (@MichaelMure) - [ ]...