David Li
David Li
There are lint errors https://github.com/apache/arrow/actions/runs/3290191393/jobs/5426029066#step:6:7990 ``` [WARN] /arrow/java/dataset/src/main/java/org/apache/arrow/dataset/scanner/ArrowScannerReader.java:28: Wrong order for 'java.io.IOException' import. [ImportOrder] [WARN] /arrow/java/dataset/src/main/java/org/apache/arrow/dataset/scanner/ArrowScannerReader.java:31: Missing a Javadoc comment. [JavadocType] [WARN] /arrow/java/dataset/src/main/java/org/apache/arrow/dataset/scanner/ArrowScannerReader.java:39:3: Missing a Javadoc comment. [JavadocMethod] [WARN] /arrow/java/dataset/src/main/java/org/apache/arrow/dataset/scanner/ArrowScannerReader.java:61:...
Can you rebase to see if the CI issue is fixed?
There's still a lint error here ``` Warning: src/main/java/org/apache/arrow/dataset/scanner/ArrowScannerReader.java:[43,3] (javadoc) JavadocMethod: Missing a Javadoc comment. ```
Accompanies https://github.com/apache/arrow-site/pull/236 Rendered: 
whoops, that should've been 17**7**32, thanks
CC @jduo, does this look reasonable as a basic landing page?
@davisusanibar @lwhite1 could one of you give this a skim? It would be good to have documentation for our shiny new driver.
We should probably add a unit test for this
No, although looking at it, the fix is a little weird - it means we're comparing data of two different types, or the data doesn't match its type? Regardless, it...
I think it's OK to have this, I wonder why the comparison doesn't start with a type comparison though (which should avoid this class of issues)