dataclasses-json icon indicating copy to clipboard operation
dataclasses-json copied to clipboard

fix(mm): Replace deprecated Marshmallow Field parameters

Open stevenpackardblp opened this issue 2 years ago • 11 comments

In Marshmallow 3.13.0, the default and missing parameters of the Field object were deprecated and replaced with dump_default and load_default respectively. As these are new parameters added in version 3.13.0, the minimum version requirement is bumped accordingly.

fixes: #328

stevenpackardblp avatar Apr 09 '22 07:04 stevenpackardblp

This would be nice to clean up the warning spews!

stevenpackardblp avatar Aug 25 '22 12:08 stevenpackardblp

In case anyone is seeing hundreds of errors, is waiting on this fix to be merged (and uses pytest) adding the following to a pytest.ini file will suppress these warnings:

[pytest]
filterwarnings =
    ignore::DeprecationWarning:marshmallow*
    ignore::DeprecationWarning:dataclasses_json*

camin-mccluskey avatar Sep 25 '22 12:09 camin-mccluskey

I would love for this fix to be merged!

andret13pinto avatar Jan 18 '23 14:01 andret13pinto

@stevenpackardblp please update your PR and we can merge ;)

george-zubrienko avatar Jul 01 '23 07:07 george-zubrienko

@stevenpackardblp another ping :) if no reply in a week I'll take over this PR and re-create it

george-zubrienko avatar Jul 20 '23 22:07 george-zubrienko

@stevenpackardblp another ping :) if no reply in a week I'll take over this PR and re-create it

Let me refresh my workspace this week and see if I can get this rebased. Apologies for missing the first ping.

stevenpackardblp avatar Jul 24 '23 19:07 stevenpackardblp

it would be great if this could be merged 🙏

russwinch avatar Sep 20 '23 16:09 russwinch

Agree, would be great if this could be addressed!

rbreslavsky avatar Jan 31 '24 22:01 rbreslavsky

@george-zubrienko big apologies for the delay, I just rebased it.

stevenpackardblp avatar Feb 02 '24 16:02 stevenpackardblp

rebased again.

stevenpackardblp avatar May 08 '24 19:05 stevenpackardblp