mobile icon indicating copy to clipboard operation
mobile copied to clipboard

Fix: Null check exception in broadcast screen

Open andy-ife opened this issue 9 months ago • 2 comments

Fixes #1586. Code should work, but it would be helpful if steps to reproduce the error are provided for testing purposes @veloce

andy-ife avatar Mar 28 '25 18:03 andy-ife

All I have is the stack trace that I have now added to the issue @andy-ife

veloce avatar Mar 29 '25 07:03 veloce

A similar crash happened here #1544.

Both crashes happen after calling _syncRound according to the stack trace. It would easier if we would just invalidate the provider in _syncRound instead and I think it might solve the crashes we are seeing.

julien4215 avatar Mar 29 '25 15:03 julien4215

A similar crash happened here #1544.

Both crashes happen after calling _syncRound according to the stack trace. It would easier if we would just invalidate the provider in _syncRound instead and I think it might solve the crashes we are seeing.

Yes but then in the view we need to make sure we don't see any flash.

veloce avatar Apr 01 '25 08:04 veloce

Better fix here: https://github.com/lichess-org/mobile/pull/1601

It was not possible to use invalidateSelf because of the way the observed games work.

veloce avatar Apr 01 '25 09:04 veloce