lila
lila copied to clipboard
lichess-org
Enhancement: Icons in the profile charts should match time/variant icons
The icons on the profile charts should not be arbitrary, instead they should be the same icons used throughout the site including on the left panel of the profile page. This would make the charts more readable and intuitive.
If you are then it won't match the color of the chart
Agreed - but flair icons for t/c and variants could be used? Given that we can edit the colour of each line of the charts, am not familiar with chart.js stuff
We should maintain the colours on the chart, and just colour the time/variant icons from their current white, to the colour on the chart for each time/variant.
Hello, I took a shot at implementing your suggestion. While I do think that the tooltip looks better, I think that the point visibility majorly suffers. Keeping the markers while only changing the tooltip is bad (see https://github.com/lichess-org/lila/issues/13655). Therefore, I will not push forward with it.
| With Icons | Without Icons |
|---|---|
That's a good point, although I there might be ways of improving visibility in both of your images above.
- I think the icons should be in front of the lines. For example with the Correspondence yellow icon it is behind the blue line which makes it harder to see.
- If a solid or semi-transparent white\grey coloured square was behind the icons in the chart visibility for the chart with icons would dramatically improve
- I am not totally sure about this one but perhaps the icons could be staggered a bit. For example the classical and crazyhouse icons overlap. Would it be possible to, say, move the rapid icon a bit earlier in the line in the case of overlaps? Would this improve visibility or cause visual discomfort?
Not sure if this is trivial or very hard/impossible with chart.js though so not sure how realistic an implementation would be